tests: add tests for writing hive-partitioned parquet #9316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshauck
commented
Feb 22, 2024
| } | ||
|
|
||
| #[tokio::test] | ||
| async fn write_parquet_results() -> Result<()> { |
Contributor
Author
There was a problem hiding this comment.
This is the moved test.
tshauck
commented
Feb 22, 2024
| Ok(()) | ||
| } | ||
|
|
||
| #[tokio::test] |
Contributor
Author
There was a problem hiding this comment.
This is the new test.
Jefffrey
approved these changes
Feb 24, 2024
Contributor
Jefffrey
left a comment
There was a problem hiding this comment.
Looks good, thanks for adding the test 👍
Small nit is making the PR title more descriptive, such as tests: add tests for writing hive-partitioned parquet 🙂
Contributor
|
Thanks again @tshauck |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #9237
Rationale for this change
Took this open ticket which was to update the tests around the parquet partition writing feature... #9237 (comment)
What changes are included in this PR?
Test updates
Are these changes tested?
The changes are tests :)
Are there any user-facing changes?
No