Support CopyTo::partition_by in datafusion proto #9306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hoang Pham <a2k40pbc@gmail.com>
Signed-off-by: Hoang Pham <a2k40pbc@gmail.com>
devinjdangelo
approved these changes
Feb 21, 2024
Contributor
devinjdangelo
left a comment
There was a problem hiding this comment.
This looks good to me. Thank you for knocking this out! 🙏
cc @andygrove in case you notice anything that may impact Ballista here
| /// The file format to output (explicitly defined or inferred from file extension) | ||
| pub file_format: FileType, | ||
| /// Detmines which, if any, columns should be used for hive-style partitioned writes | ||
| /// Determines which, if any, columns should be used for hive-style partitioned writes |
Contributor
There was a problem hiding this comment.
Thank you for catching this typo 😅
Dandandan
approved these changes
Feb 25, 2024
Contributor
|
Thanks @PhVHoang |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #9248
Rationale for this change
Support serialization/deserialization
CopyTo::partition_byin datafusion protoWhat changes are included in this PR?
Code, tests
Are these changes tested?
Yes
Are there any user-facing changes?