Skip to content

Conversation

@comphead
Copy link
Contributor

Which issue does this PR close?

Part of #7360.

Rationale for this change

Add exec_err! error macro to replace DatafusionError::Execution with more concise code and make error handling in single place

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added sql SQL Planner logical-expr Logical plan and expressions physical-expr Changes to the physical-expr crates optimizer Optimizer rules core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) substrait Changes to the substrait crate labels Aug 22, 2023
@comphead comphead mentioned this pull request Aug 22, 2023
23 tasks
@comphead comphead marked this pull request as draft August 22, 2023 01:38
@comphead comphead marked this pull request as ready for review August 22, 2023 17:41
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As always, thank you for your contributions @comphead -- this looks like a great continued improvement and I will merge it in to avoid accumulating conflicts

@alamb alamb merged commit 46cdb8c into apache:main Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate logical-expr Logical plan and expressions optimizer Optimizer rules physical-expr Changes to the physical-expr crates sql SQL Planner sqllogictest SQL Logic Tests (.slt) substrait Changes to the substrait crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants