Skip to content

Conversation

@comphead
Copy link
Contributor

Which issue does this PR close?

Closes #.

Related to #6740 #7115

Rationale for this change

Add not_impl_err! error macro to replace DatafusionError::NotImplemented with more concise code and make error handling in single place

What changes are included in this PR?

Are these changes tested?

Yes

Are there any user-facing changes?

No

@github-actions github-actions bot added sql SQL Planner logical-expr Logical plan and expressions physical-expr Changes to the physical-expr crates core Core DataFusion crate substrait Changes to the substrait crate labels Aug 19, 2023
@comphead comphead marked this pull request as ready for review August 19, 2023 17:06
@alamb
Copy link
Contributor

alamb commented Aug 21, 2023

Thank you @comphead and @yjshen !

@alamb alamb merged commit a514b67 into apache:main Aug 21, 2023
@comphead comphead mentioned this pull request Aug 21, 2023
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate logical-expr Logical plan and expressions physical-expr Changes to the physical-expr crates sql SQL Planner substrait Changes to the substrait crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants