Skip to content

Conversation

@comphead
Copy link
Contributor

@comphead comphead commented Aug 15, 2023

Which issue does this PR close?

Related to #6740 #7115

Closes #.

Rationale for this change

Add internal_err! error macro to replace DatafusionError::Internal with more concise code and make error handling in single place

What changes are included in this PR?

Are these changes tested?

Yes

Are there any user-facing changes?

No

@github-actions github-actions bot added sql SQL Planner logical-expr Logical plan and expressions physical-expr Changes to the physical-expr crates optimizer Optimizer rules core Core DataFusion crate substrait Changes to the substrait crate labels Aug 15, 2023
@comphead comphead marked this pull request as ready for review August 15, 2023 19:02
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Epic work @comphead -- I think this looks like a very nice cleanup 🦾 . I am going to merge this in quickly as it doesn't change semantics and it has a high potential for merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate logical-expr Logical plan and expressions optimizer Optimizer rules physical-expr Changes to the physical-expr crates sql SQL Planner substrait Changes to the substrait crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants