Update to object_store 0.6 and arrow 41 #6374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
commented
May 17, 2023
| builder = builder.with_token(session_token); | ||
| } | ||
| } else { | ||
| let config = aws_config::from_env().load().await; |
Contributor
Author
There was a problem hiding this comment.
Unlike before, this now ensures that users get the full coherent configuration experience that they might expect from a CLI tool.
Contributor
There was a problem hiding this comment.
cc @r4ntix as I think you contributed some of the previous configuration code
Contributor
Contributor
Author
|
Waiting for apache/arrow-rs#4251 |
ec53cb3 to
4f24b3f
Compare
4f24b3f to
df5199a
Compare
alamb
approved these changes
Jun 6, 2023
tustvold
commented
Jun 6, 2023
| ctx.register_listing_table( | ||
| "my_table", | ||
| &format!("file://{testdata}"), | ||
| &format!("file://{testdata}/alltypes_plain.parquet"), |
Contributor
Author
There was a problem hiding this comment.
This is a nice validation of https://github.com/apache/arrow-rs/issues/4230 being a valuable change. This test was broken, as the lack of a trailing / meant it wouldn't list the directory, and this meant it silently failed to list any files. Schema inference fails on the root directory (correctly) so I changed this to a single file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
The next release of object_store contains a number of breaking changes, lets verify them before cutting the release
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?