Remove optimize_children and replace with map_children #5984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Apr 13, 2023
Contributor
alamb
left a comment
There was a problem hiding this comment.
Looks good to me -- thank you @2010YOUY01
There appears to be a conflict now with this PR -- can you please resolve that?
Also I think the doctest CI failure will be resolved by merging up from main (it was fixed by @yjshen in #5989)
Contributor
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5762.
Rationale for this change
NA
What changes are included in this PR?
optimize_children()optimize_children()withmap_children()in aggregate_statistics.rs(Also changed argument from
configto_configto fix linter error)Are these changes tested?
This is a refactor inside optimize(), this function is already covered by existing tests
Are there any user-facing changes?
No