Skip to content

MINOR: Add datafusion-cli documentation on showing configuration #3825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
andygrove merged 2 commits into from
Oct 14, 2022
Merged

MINOR: Add datafusion-cli documentation on showing configuration #3825

andygrove merged 2 commits into from
Oct 14, 2022

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Oct 13, 2022

Which issue does this PR close?

N/A

Rationale for this change

I love SHOW ALL added by @waitingkuo in #3455

It also took me some rummaging around in the code to figure out how to control the settings.

What changes are included in this PR?

Document how to show/change config in datafusion-cli

Are there any user-facing changes?

Docs

@alamb alamb marked this pull request as ready for review October 13, 2022 17:48
@alamb alamb changed the title Minor: Add datafusion-cli documentation on showing configuration MINOR: Add datafusion-cli documentation on showing configuration Oct 13, 2022
andygrove
andygrove approved these changes Oct 14, 2022
View reviewed changes
Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding more docs!

@andygrove andygrove merged commit 716d1ed into apache:master Oct 14, 2022
@ursabot
Copy link

ursabot commented Oct 14, 2022

Benchmark runs are scheduled for baseline = 0aa050a and contender = 716d1ed. 716d1ed is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb alamb deleted the alamb/config_in_cli branch October 14, 2022 18:44
@alamb alamb mentioned this pull request Oct 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andygrove andygrove andygrove approved these changes

@paddyhoran paddyhoran paddyhoran approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alamb @ursabot @andygrove @paddyhoran