CI: Add a new run to check whether datafusion-cli lock file is up-to-date
#3745
Conversation
|
Want to make sure first that it fails (since the lock is out-of-date now) and I will also include the regenerated version, though the CI does not start without a maintainer's approval. |
| - name: Check workspace with all features | ||
| run: | | ||
| cargo check --workspace --benches --features avro,jit,scheduler,json | ||
| - name: Check Cargo.lock for datafusion-cli |
There was a problem hiding this comment.
👍
I ran this locally and it worked great for me, FWIW
| target | ||
| Cargo.lock | ||
| !datafusion-cli/Cargo.lock | ||
| !ballista-cli/Cargo.lock |
|
@isidentical it appears this test did not fail so I am not sure what the status of the PR is -- marking it as "draft" (to help keep the list of PRs ready to review small). Please mark it as ready to review when it is. Thanks! |
|
@alamb I already have confirmed that it worked with the action failing (and then submitted the changes on the Cargo.lock as well, so that they won't fail now). The PR should be good for a review as is (if I am not missing anything). |
|
Cool -- thanks @isidentical -- I couldn't tell from the github PR history. |
datafusion-cli lock file is up-to-date
|
Thanks again @isidentical |
|
Benchmark runs are scheduled for baseline = a9ee674 and contender = 58afdf7. 58afdf7 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #3744.
Rationale for this change
This adds a new script (that only runs on the CI, so a classic
./dev/rust_lint.shdoesn't waste its time on this check) that ensures the lock file for the datafusion-cli is up-to-date.