Skip to content

Add SQL query planner support for time literal #2884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
andygrove wants to merge 1 commit into from
Closed

Add SQL query planner support for time literal #2884

andygrove wants to merge 1 commit into from

Conversation

@andygrove
Copy link
Member

@andygrove andygrove commented Jul 12, 2022 •
edited
Loading

Which issue does this PR close?

Part of #2883

Rationale for this change

Support more SQL in the SQL query planner

What changes are included in this PR?

Add support for TIME literal values in SQL query planner

Are there any user-facing changes?

No

@andygrove andygrove marked this pull request as draft July 12, 2022 16:21
@github-actions github-actions bot added the sql SQL Planner label Jul 12, 2022
@andygrove
Copy link
Member Author

andygrove commented Jul 12, 2022

Converting to draft as this isn't enough.

SELECT TIME '08:08:00.091' AS "T";
Internal("Unsupported CAST from Utf8 to Time32(Millisecond)")

@andygrove andygrove changed the title Add support for time literal in SQL Add SQL query planner support for time literal Jul 12, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2022

Codecov Report

Merging #2884 (3b9c2a2) into master (d25e822) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2884      +/-   ##
==========================================
+ Coverage   85.25%   85.35%   +0.09%     
==========================================
  Files         275      276       +1     
  Lines       49010    49295     +285     
==========================================
+ Hits        41785    42075     +290     
+ Misses       7225     7220       -5
Impacted Files Coverage Δ
datafusion/sql/src/planner.rs 81.42% <100.00%> (+0.04%) ⬆️
datafusion/expr/src/window_frame.rs 92.43% <0.00%> (-0.85%) ⬇️
datafusion/common/src/scalar.rs 75.77% <0.00%> (-0.12%) ⬇️
datafusion/core/tests/sql/timestamp.rs 100.00% <0.00%> (ø)
datafusion/physical-expr/src/expressions/mod.rs 100.00% <0.00%> (ø)
datafusion/physical-expr/src/expressions/delta.rs 100.00% <0.00%> (ø)
datafusion/optimizer/src/simplify_expressions.rs 82.00% <0.00%> (+0.02%) ⬆️
...tafusion/physical-expr/src/expressions/datetime.rs 86.80% <0.00%> (+54.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d25e822...3b9c2a2. Read the comment docs.

@alamb
Copy link
Contributor

alamb commented Aug 13, 2022

Possibly related / redundant with @stuartcarnie 's #3010

@stuartcarnie stuartcarnie mentioned this pull request Aug 15, 2022
Merged
@andygrove
Copy link
Member Author

andygrove commented Aug 15, 2022

Closing this in favor of #3010

@andygrove andygrove closed this Aug 15, 2022
@andygrove andygrove deleted the time-literal branch August 15, 2022 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

sql SQL Planner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andygrove @codecov-commenter @alamb