bugfix: preserve schema metadata for record batch in FFI #19293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethan-tyler
reviewed
Dec 12, 2025
Contributor
ethan-tyler
left a comment
There was a problem hiding this comment.
Thanks for the PR @timsaucer!
This LGTM. Reviewed the changes and ran cargo test -p datafusion-ffi round_trip_record_batch_with_metadata -- --nocapture locally.
Unrelated to your changes, but I noticed the existing test_round_trip_record_batch_stream doesn't have schema metadata on its test batch. Might be worth adding metadata there too at some point so the streaming path has explicit coverage.
renato2099
approved these changes
Dec 13, 2025
72cebe5 to
1f18a4d
Compare
Member
Author
|
Thank you for the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Metadata on a schema for a record batch is lost during FFI conversion. This is not always obvious because our other integrations like
ExecutionPlanandTableProviderhave their own ways to provide the schema.This is currently an issue because we have FFI table providers who say they have a specific schema but the schema of the actual record batches does not match. The metadata is dropped.
What changes are included in this PR?
We already have the schema in the FFI object, so use it both when converting to and from FFI.
Are these changes tested?
Unit test added.
Are there any user-facing changes?
No