feat: Move DefaultMetadataCache into its own module #19125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements apache#19074 Separates DefaultFilesMetadataCache into its own module following the same pattern as DefaultListFilesCache to improve organization of the cache module.
petern48
approved these changes
Dec 7, 2025
adriangb
reviewed
Dec 7, 2025
alamb
approved these changes
Dec 7, 2025
Contributor
alamb
left a comment
There was a problem hiding this comment.
Thank you @AryanBagade @petern48 and @adriangb
I think it would be great to add a pub use as suggested by @adriangb to help upgrades
cc @BlakeOrth
Contributor
Author
|
sure will add it!!! |
BlakeOrth
approved these changes
Dec 8, 2025
Contributor
BlakeOrth
left a comment
There was a problem hiding this comment.
This looks great to me, thank you!
Contributor
|
🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Implements #19074
Rationale for this change
As the default cache implementations expand, the module structure under
datafusion/execution/src/cache/has become crowded. This PR continues the pattern established in #18855 by separatingDefaultFilesMetadataCacheinto its own module to improve code organization and maintainability.What changes are included in this PR?
file_metadata_cache.rsmodule containing:DefaultFilesMetadataCacheState(internal state management)DefaultFilesMetadataCache(public struct and implementation)FileMetadataCacheandCacheAccessor)mod.rsto declare and export the new modulecache_manager.rsto import from new locationcache_unit.rs(reduced from 863 to 159 lines)Are these changes tested?
Yes, all existing tests have been moved to the new module and pass successfully
Are there any user-facing changes?
No user-facing changes. This is purely an internal code organization refactoring.