Refactor power() signature away from user defined
#18968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jefffrey
commented
Nov 27, 2025
Comment on lines
+304
to
+310
| // Null propagation | ||
| if base_type.is_null() || exponent_type.is_null() { | ||
| let return_type = self.return_type(&[base_type, exponent_type])?; | ||
| return Ok(ExprSimplifyResult::Simplified(lit( | ||
| ScalarValue::Null.cast_to(&return_type)? | ||
| ))); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Similar to what we do for log:
datafusion/datafusion/functions/src/math/log.rs
Lines 278 to 283 in c6f7363
| } | ||
|
|
||
| #[test] | ||
| fn test_power_f64() { |
Contributor
Author
There was a problem hiding this comment.
Moved these to SLTs
martin-g
reviewed
Nov 27, 2025
alamb
approved these changes
Dec 15, 2025
| fn invoke_with_args(&self, args: ScalarFunctionArgs) -> Result<ColumnarValue> { | ||
| let base = &args.args[0].to_array(args.number_rows)?; | ||
| let exponent = &args.args[1]; | ||
| let [base, exponent] = take_function_args(self.name(), &args.args)?; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Signature::user_definedfor normal functions #12725Rationale for this change
Prefer to avoid user_defined for consistency in function definitions.
What changes are included in this PR?
Refactor signature of power away from user_defined.
Are these changes tested?
Existing tests.
Are there any user-facing changes?
No.