Use LimitedBatchCoalescer in FilterExec
#18783
Draft
+18
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-g
reviewed
Nov 17, 2025
| self.push_batch(filter_record_batch(&batch, filter)?) | ||
| } else { | ||
| // use optimized path when no fetch limit is set | ||
| self.inner.push_batch_with_filter(batch, filter)?; |
Member
There was a problem hiding this comment.
What about the total_rows ? Does it need to be updated in the optimized path ?
Contributor
Author
There was a problem hiding this comment.
you are right -- I will try and fix this
| batch: RecordBatch, | ||
| filter: &arrow::array::BooleanArray, | ||
| ) -> Result<PushBatchStatus> { | ||
| // If there is a limit, fall back to the non-optimized path |
Member
There was a problem hiding this comment.
There is no check for self.finished as in push_batch().
|
Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Complete a TODO from #18630 (comment) from @Dandandan
datafusion/datafusion/physical-plan/src/filter.rs
Line 781 in bd30fe2
I am hoping to drive more optimizations into
BatchCoalescerover time so I want to send as much through to the underlying arrow kernel as possibleWhat changes are included in this PR?
LimitedBatchCoalescer::push_batch_with_filterAre these changes tested?
By existing CI
Are there any user-facing changes?
No