Support JOIN, PIVOT pipe operators
#17365
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
443fdc1 to
dc60f73
Compare
dc60f73 to
b584074
Compare
Contributor
Author
|
Merged up from main, ready for review. |
Jefffrey
reviewed
Oct 8, 2025
Contributor
Jefffrey
left a comment
There was a problem hiding this comment.
Should we split this PR to only be for JOIN, and do PIVOT in a separate PR where it can hopefully use pivot from the logical plan builder if/when it gets merged?
Contributor
Author
|
Good idea, created #17969 |
|
Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #14660
Rationale for this change
Draft until #17946 is merged. Then we can use the LogicalPlanBuilder
sqlparser 0.58 released with support for parsing pipe operators.
Let's see if we can make Datafusion support executing them.
What changes are included in this PR?
Support for the following pipe operators
I did not find any support for the pivot operation in Datafusion, so I added an initial implementation. This code could probably be used in a later PR to fix #12907
Are these changes tested?
Yes, I have added SLT tests
Are there any user-facing changes?
Yes, if the dialect is set to one that supports pipe operators, those can then be executed.