Skip to content

Fix extended tests failure on main by updating datafusion-testing pin #17176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Jefffrey merged 1 commit into from
Aug 13, 2025
Merged

Fix extended tests failure on main by updating datafusion-testing pin #17176

Jefffrey merged 1 commit into from
Aug 13, 2025

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Aug 13, 2025 •
edited
Loading

Which issue does this PR close?

Rationale for this change

Several changes have allowed more queries to run (that were previously erroring) so the test output needed to be updated. @Jefffrey @findepi @Omega359 and I have reviewed the tests updates, see apache/datafusion-testing#10

What changes are included in this PR?

Note I did not add a

Are these changes tested?

I tested manually with this test

INCLUDE_SQLITE=true cargo test --profile release-nonlto --test sqllogictests

It was successful

    Finished `release-nonlto` profile [optimized] target(s) in 1m 48s
     Running bin/sqllogictests.rs (target/release-nonlto/deps/sqllogictests-a9585b1f5167b5e7)
Completed 941 test files in 6 minutes                                                                                                                                                        (venv) andrewlamb@Andrews-MacBook-Pro-3:~/Software/datafusion$ top
(venv) andrewlamb@Andrews-MacBook-Pro-3:~/Software/datafusion$

Are there any user-facing changes?

Note I did not add a note in the upgrading guide, per the discussion on apache/datafusion-testing#10 (comment).

@alamb alamb mentioned this pull request Aug 13, 2025
Closed
@alamb alamb added the development-process Related to development process of DataFusion label Aug 13, 2025
Jefffrey
Jefffrey approved these changes Aug 13, 2025
View reviewed changes
Copy link
Contributor

@Jefffrey Jefffrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Jefffrey Jefffrey merged commit c2714db into apache:main Aug 13, 2025
29 checks passed
@alamb
Copy link
Contributor Author

alamb commented Aug 13, 2025

Thank you @Jefffrey 🙏

@alamb alamb deleted the alamb/fix_extended_tests2 branch August 13, 2025 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jefffrey Jefffrey Jefffrey approved these changes

Assignees

No one assigned

Labels

development-process Related to development process of DataFusion

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Extended tests are failing on main

2 participants

@alamb @Jefffrey