Fix [Bug] Aggregate + TopK fails when asc = false #16972
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@niebayes can you please help review this PR and ensure it solves your issue? |
alamb
approved these changes
Jul 30, 2025
Contributor
alamb
left a comment
There was a problem hiding this comment.
Thank you @avantgardnerio -- this looks good to me
Contributor
|
@avantgardnerio @alamb Thank you. I've confirmed this path solved the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Solve issue 16837
What changes are included in this PR?
Pass full datatype though to output in
PrimitiveHashTableAre these changes tested?
A unit test was added. It failed, then it didn't.
Are there any user-facing changes?
More queries should work.