Fix array_has to return false for empty arrays instead of null #16529
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
The
array_hasfunction incorrectly returnsnullfor empty arrays, which should logically returnfalsesince an empty array cannot contain any element. This leads to inconsistencies and incorrect query results. The change ensures thatarray_hasreturns the correct boolean outcome when applied to empty arrays.What changes are included in this PR?
array_has_dispatch_for_scalarfunction to check the array validity buffer and differentiate between null and empty arrays.falseand null arrays continue to returnnull.array_has_table_empty) to verify the updated behavior.Are these changes tested?
Yes, new test cases were added to the SQL logic test file
array.sltto verify that:true.false.null.Are there any user-facing changes?
Yes:
array_has([], value)now returnsfalseinstead ofnull, improving correctness and predictability for users.