[wip] update list & struct coercion to support incrementality #15259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f20e081 to
26e2e9a
Compare
alamb
reviewed
May 7, 2025
| } | ||
|
|
||
| #[test] | ||
| fn test_struct_coercion() { |
Contributor
There was a problem hiding this comment.
The basic idea looks good -- I think we would need to add some sqllogictests that show what we want to happen in order to evaluate any actual code solution
Sorry for the delay @TheBuilderJR
|
Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@alamb can I get a quick sanity check to see if this is the right direction? FWIW this does fix my test case in #14757. if so can you give me a quick code pointer to where I should put a test? thanks in advance!