implement tree rendering for StreamingTableExec #15085
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
reviewed
Mar 8, 2025
Contributor
alamb
left a comment
There was a problem hiding this comment.
Thank you @Standing-Man -- this is very nice contribution ❤️
I think we should make the display simpler -- let me know what you think
Signed-off-by: Alan Tang <jmtangcs@gmail.com>
d31bb49 to
26e6cb8
Compare
Signed-off-by: Alan Tang <jmtangcs@gmail.com> chore: Describe more precisely Signed-off-by: Alan Tang <jmtangcs@gmail.com>
26e6cb8 to
40397bb
Compare
Contributor
|
I also verified the tests pass after merging to main locally. Thanks again @Standing-Man |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
SQL EXPLAINTree Rendering #14914 and Implement tree rendering forStreamingTableExec#15086.Rationale for this change
What changes are included in this PR?
implement tree rendering for StreamingTableExec
Are these changes tested?
yes
Are there any user-facing changes?