AggregateUDFImpl::schema_name and AggregateUDFImpl::display_name for customizable name
#14695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Feb 16, 2025
Contributor
alamb
left a comment
There was a problem hiding this comment.
Thanks @jayzhan211 -- this makes sense to me
| if let Some(null_treatment) = null_treatment { | ||
| write!(f, " {}", null_treatment)?; | ||
| Expr::AggregateFunction(AggregateFunction { func, params }) => { | ||
| match func.schema_name(params) { |
Closed
AggregateUDFImpl::schema_name for customizable schema nameAggregateUDFImpl::schema_name and AggregateUDFImpl::display_name for customizable name
Contributor
Author
|
Add display name as well |
alamb
approved these changes
Feb 17, 2025
Contributor
alamb
left a comment
There was a problem hiding this comment.
Looks great -- thanks @jayzhan211
Contributor
Author
|
Thanks @alamb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Similar to ScalarFunction, we can modify the schema name to the one we want.
We need this for #14689
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?