Skip to content

Conversation

@xudong963
Copy link
Member

@xudong963 xudong963 commented Feb 12, 2025

Which issue does this PR close?

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the physical-expr Changes to the physical-expr crates label Feb 12, 2025
@github-actions github-actions bot added the sqllogictest SQL Logic Tests (.slt) label Feb 12, 2025
@xudong963
Copy link
Member Author

The pr is fixing main ci once the ci of the pr passes I'll merge it.

Copy link
Contributor

@zhuqi-lucas zhuqi-lucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jayzhan211 jayzhan211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@xudong963 xudong963 merged commit 02cc22e into apache:main Feb 12, 2025
24 checks passed
@xudong963
Copy link
Member Author

thanks all

@alamb
Copy link
Contributor

alamb commented Feb 12, 2025

Thank you @xudong963 and @jayzhan211

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

physical-expr Changes to the physical-expr crates sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants