Skip to content

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Feb 8, 2025

Which issue does this PR close?

Rationale for this change

This currently fails on main:

INCLUDE_SQLITE=true cargo test --test sqllogictests

Because this PR improves the error messages and we need to update the expected results

What changes are included in this PR?

Update the expected results in datafusion-cli for updated results

Are these changes tested?

I tested them manually and they passed

Note @buraksenn is working on making it possible to run the extended tests from a PR so hopefully we don't have this problem again

Are there any user-facing changes?

@alamb alamb marked this pull request as ready for review February 8, 2025 13:15
@alamb
Copy link
Contributor Author

alamb commented Feb 8, 2025

Thank you @jonahgao

@alamb alamb merged commit 56a30ac into apache:main Feb 8, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extended tests are failing on main

2 participants