Improve documentation about extended tests #14320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Omega359
reviewed
Jan 27, 2025
| commit to `main`. These tests rarely fail but take significantly longer to run | ||
| than the standard test suite and add important test coverage such as that the | ||
| code works when there are hash collisions as well as running the entire [sqlite | ||
| test suite](https://www.sqlite.org/sqllogictest/dir?ci=tip). |
Contributor
There was a problem hiding this comment.
Almost the entire suite ... I do remove the evidence and index/delete/ folders.
Contributor
Author
There was a problem hiding this comment.
I updated it to say "relevant portion of the entire suite"
Contributor
comphead
reviewed
Feb 7, 2025
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
The relatively newly added
extendedsuite is an important part of DataFusion's test overage and we should make it easier to findWhat changes are included in this PR?
extendedsuiteAre these changes tested?
Are there any user-facing changes?