Skip to content

Conversation

@2010YOUY01
Copy link
Contributor

Which issue does this PR close?

Closes #.

Rationale for this change

I encountered a CI failure in https://github.com/apache/datafusion/actions/runs/11995648362/job/33439273622?pr=13540

External error: query result mismatch:
[SQL] select make_array(make_array(1)) x UNION ALL SELECT make_array(arrow_cast(make_array(-1), 'LargeList(Int8)')) x;
[Diff] (-expected|+actual)
-   [[-1]]
-   [[1]]
+   [[1]]
+   [[-1]]
at test_files/union.slt:775

I think for UNION ALL statements, output order is not deterministic
So this PR specified the output order in failed test cases.

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the sqllogictest SQL Logic Tests (.slt) label Nov 24, 2024
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @2010YOUY01

@alamb alamb changed the title Minor: Fix two test cases causing CI failures Minor: Fix two test cases causing CI failures by adding rowsort Nov 24, 2024
@alamb alamb merged commit 58018bc into apache:main Nov 24, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants