Skip to content

[docs]: migrate lead/lag window function docs to new docs #13095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alamb merged 2 commits into from
Oct 24, 2024
Merged

[docs]: migrate lead/lag window function docs to new docs #13095

alamb merged 2 commits into from
Oct 24, 2024

Conversation

@buraksenn
Copy link
Contributor

@buraksenn buraksenn commented Oct 24, 2024

Which issue does this PR close?

Partially #12936

Rationale for this change

Part of #12740

What changes are included in this PR?

  • migrate to new doc
  • delete lead/lag from static docs

Are these changes tested?

  • documentation change

Are there any user-facing changes?

only documentation change

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 24, 2024
@Omega359
Copy link
Contributor

Omega359 commented Oct 24, 2024

Thank you for migrating this documentation! Would it be possible to add sql examples for each? If not I can file a followup PR to have those added to the docs for these functions and others that may be missing the examples.

@buraksenn
Copy link
Contributor Author

buraksenn commented Oct 24, 2024

Thank you for migrating this documentation! Would it be possible to add sql examples for each? If not I can file a followup PR to have those added to the docs for these functions and others that may be missing the examples.

I can add for lead/lag now in this PR. When I migrate window functions I can include sql examples

@Omega359 Omega359 mentioned this pull request Oct 24, 2024
Closed
26 tasks
alamb
alamb approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @buraksenn and @Omega359

Let's merge this PR in now and do the examples as a follow on. I would really like to get to the point where we have all the documentation migrated directly to the new pages.

🚀

@alamb alamb merged commit 9e636d8 into apache:main Oct 24, 2024
@alamb alamb mentioned this pull request Oct 29, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alamb alamb alamb approved these changes

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@buraksenn @Omega359 @alamb