fix: incorrect aggregation result of bool_and
#12017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Aug 15, 2024
| self.values.append_n(new_groups, Default::default()); | ||
| // Fill with the identity element, so that when the first non-null value is encountered, | ||
| // it will combine with the identity and the result will be the first non-null value itself. | ||
| self.values.append_n(new_groups, self.identity); |
Contributor
There was a problem hiding this comment.
Nice -- this is similar to the default value for the PrimitiveOp accumulator too
Member
Author
|
Thanks for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #11846.
Rationale for this change
The initial value of each group was set to
false. When encountering the first non-null value of a certain group and performing the AND operation with the initial value, it resulted in an incorrect output.We should set the initial value to the identity element.
What changes are included in this PR?
Are these changes tested?
Yes
Are there any user-facing changes?
No