Improve AccumulatorArgs by removing the usgaes of input_types
#11761
Conversation
AccumulatorArgs by Removing the usgaes of schema and input_typesAccumulatorArgs by removing the usgaes of schema and input_types
There was a problem hiding this comment.
This looks weird that moving a physical expr into logical expr crate.
There was a problem hiding this comment.
Ya, today the physical-expr-common references the expr, the dependency results in weird behavior. It might be better to isolate logic-expr physical-expr and move the code that references both, e.g., udf, udaf etc. another project.
There was a problem hiding this comment.
@xinlifoobar We should not move physical-expr in expr, what is the issue you met that needs the move?
There was a problem hiding this comment.
We might to the refactor #11359 before removing input_types
There was a problem hiding this comment.
THank you all for this -- yes getting the physical-expr and Expr types untangled will be a great step. I agree with @jayzhan211 that #11359 might be good to look at first
AccumulatorArgs by removing the usgaes of schema and input_typesAccumulatorArgs by removing the usgaes of input_types
|
@xinlifoobar I plan to resolve the issue together in #11845 , so we can step forward to the final state at once |
|
Superceded by #11845 I think, so marking it as draft as it isn't waiting for review |
Which issue does this PR close?
Part of #11725
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?