Make ArragAgg (not ordered or distinct) into a UDAF #11045
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 21, 2024
jayzhan211
reviewed
Jun 21, 2024
| "ARRAY_AGG(DISTINCT aggregate_test_100.c2)", | ||
| Field::new("item", DataType::UInt32, true), | ||
| false | ||
| true |
Contributor
There was a problem hiding this comment.
I think nullable should be fixed together otherwise the test seems like regression to me 🤔
Contributor
Author
There was a problem hiding this comment.
I noticed that we need further changes to resolve this one. See my comment here: #11063
jayzhan211
reviewed
Jun 21, 2024
jayzhan211
reviewed
Jun 21, 2024
jayzhan211
reviewed
Jun 21, 2024
| let simplify = |aggregate_function: AggregateFunction, _: &dyn SimplifyInfo| { | ||
| if aggregate_function.order_by.is_some() || aggregate_function.distinct { | ||
| Ok(Expr::AggregateFunction(AggregateFunction { | ||
| func_def: AggregateFunctionDefinition::BuiltIn( |
jayzhan211
reviewed
Jun 21, 2024
This follows how it done for input_type and only provide a single value. But might need to be changed into a Vec in the future. This is need when we are moving `arrag_agg` to udaf where one of the states nullability will depend on the nullability of the input.
2939e80 to
47ab253
Compare
Contributor
|
Thanks @eejbyfeldt and @jayzhan211 -- this PR seems to be failing CI so I am marking it as a draft until that gets sorted out. I am working on reducing the review backlog |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #8708
Closes #10999.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Existing tests.
Are there any user-facing changes?
This adds UDAF for
ARRAY_AGGwhen it not disitinct or ordered. The distinct and ordered will be handled in future PRs.