Skip to content

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented May 2, 2024

Which issue does this PR close?

Closes #10352

Rationale for this change

Rust 1.78 was released and has some new clippy lints

What changes are included in this PR?

  1. Fix all clippy lints

Are these changes tested?

existing CI

Are there any user-facing changes?

No, all internal code arrangements

@alamb alamb changed the title Alamb/fix clippy Fix clippy lints found by 1.78 May 2, 2024
@github-actions github-actions bot added logical-expr Logical plan and expressions optimizer Optimizer rules core Core DataFusion crate labels May 2, 2024
@alamb alamb changed the title Fix clippy lints found by 1.78 Fix clippy lints found by Clippy in Rust 1.78 May 2, 2024
@alamb alamb mentioned this pull request May 2, 2024
@alamb alamb added the development-process Related to development process of DataFusion label May 2, 2024
Copy link
Contributor

@Omega359 Omega359 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@viirya
Copy link
Member

viirya commented May 2, 2024

Looks like there are more.

@github-actions github-actions bot removed the development-process Related to development process of DataFusion label May 2, 2024
@alamb
Copy link
Contributor Author

alamb commented May 2, 2024

Here is hoping I got them all now 🙏

@alamb alamb merged commit 97148bd into apache:main May 2, 2024
@alamb
Copy link
Contributor Author

alamb commented May 2, 2024

Thanks for the quick review @viirya and @Omega359

@alamb alamb deleted the alamb/fix_clippy branch May 2, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate logical-expr Logical plan and expressions optimizer Optimizer rules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

clippy failure in main

3 participants