Consolidate LogicalPlan tree node walking/rewriting code into one module #10034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@andygrove or @comphead is there any chance you have time for a quick review? This PR just moves code around but I don't want it to attract conflicts cc @peter-toth |
andygrove
approved these changes
Apr 10, 2024
Contributor
Author
|
Thank you @andygrove -- much appreciated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #9994
Rationale for this change
While working with the LogicalPlan treenode APIs finding it is hard as it is sprinkled in the plan.rs module. That module is also quite large. Thus, let's put it all in the same file
What changes are included in this PR?
tree_node.rsmodule (where it is documented)Are these changes tested?
Are there any user-facing changes?
This PR just moves a bunch of code around. There is no functional change