Skip to content

Use f64::total_cmp instead of OrderedFloat #4051

@tustvold

Description

@tustvold

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

DataFusion uses OrderedFloat in various places to order floats, this is different from arrow-rs which makes use of https://doc.rust-lang.org/std/primitive.f32.html#method.total_cmp.

Describe the solution you'd like

Moving away from OrderedFloat will:

  • Ensure consistency
  • Eliminate a dependency

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions