Skip to content

change rule of PreCastLitInComparisonExpressions to unwrap cast rule after #3582 #3622

@liukun4515

Description

@liukun4515

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
(This section helps Arrow developers understand the context and why for this feature, in addition to the what)

after this #3582 merged, the type coercion will be done before the optimizer.

The PreCastLitInComparisonExpressions will take affect.

For example:

schema: the data type of c is int32
select * from table c > 10;

after done the type coercion, we will get the expr like cast(c as int64) > int64(10) and the PreCastLitInComparisonExpressions will not affect the above expr.

But we can convert the int64(10) to the type of c with unwrap cast the expr cast(c as int64), it is very similar to what spark done https://issues.apache.org/jira/browse/SPARK-32858

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions