Skip to content

CoalesceBatches physical optimizer rule says it should be last but it isn't #18148

New issue
New issue
Closed as not planned
Closed as not planned
CoalesceBatches physical optimizer rule says it should be last but it isn't#18148
@Jefffrey

Description

@Jefffrey
Jefffrey
opened on Oct 18, 2025

datafusion/datafusion/physical-optimizer/src/optimizer.rs

Lines 123 to 129 in e323357

// The CoalesceBatches rule will not influence the distribution and ordering of the
// whole plan tree. Therefore, to avoid influencing other rules, it should run last.
Arc::new(CoalesceBatches::new()),
Arc::new(CoalesceAsyncExecInput::new()),
// Remove the ancillary output requirement operator since we are done with the planning
// phase.
Arc::new(OutputRequirements::new_remove_mode()),

Can see here it states CoalesceBatches rule should be last but seems this isn't the case anymore; either comment is outdated and it doesn't need to be last anymore, or we should in-fact move it down to respect the comment.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions