-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Closed
Closed
Copy link
Labels
enhancementNew feature or requestNew feature or requestperformanceMake DataFusion fasterMake DataFusion faster
Description
Is your feature request related to a problem or challenge?
@svranesevic implemented basic support for Min/Max Duration types in this PR: ❤
However, this only implements the slower "Accumulator" interface.
There is a faster GroupsAccumulator that would be really nice to implement as well as it will be faster for larger numbers of groups.
Describe the solution you'd like
See Notes on Implementing GroupsAccumulator for more detail
Describe alternatives you've considered
It basically involves
- adding the correct Durations type in the list of supported types (the one for max is here): https://github.com/apache/datafusion/blob/42ec5109bb4c6249d8404e862c457ebd86ee0623/datafusion/functions-aggregate/src/min_max.rs#L243-L242
- Instantiating an accumulator here: https://github.com/apache/datafusion/blob/42ec5109bb4c6249d8404e862c457ebd86ee0623/datafusion/functions-aggregate/src/min_max.rs#L270-L269
- Writing some tests (perhaps add a few more rows to the test added in Support Duration in min/max agg functions #15310)
Additional context
No response
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestperformanceMake DataFusion fasterMake DataFusion faster