-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Closed
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomers
Description
Is your feature request related to a problem or challenge?
in #13001 @agscpp added a general function ScalarUDFImpl::invoke_batche that handles inputs with 0 and more than 0 arguments.
Previously, there were two separate functions to handle these cases:
- https://docs.rs/datafusion/latest/datafusion/logical_expr/trait.ScalarUDFImpl.html#tymethod.invoke
- https://docs.rs/datafusion/latest/datafusion/logical_expr/trait.ScalarUDFImpl.html#method.invoke_no_args
Describe the solution you'd like
I would like to mark invoke and invoke_no_args deprecated
Describe alternatives you've considered
- Mark the functions deprecated, with a message to implement
invoke_batchinstead. for example
datafusion/datafusion/expr/src/expr.rs
Line 1125 in c22abb4
#[deprecated(note = "use format! instead")] - Update the documentation so
invoke_batchis the main API and the documentation reflects that - Update the DataFusion codebase so that the
ScalarUDFImpls use invoke_batch rather thaninvokeandinvoke_udf
Additional context
I think this is pretty well specified and largely mechanical so it would be a good first issue
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomers