-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Closed
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomers
Description
Is your feature request related to a problem or challenge?
While working on https://github.com/datafusion-contrib/datafusion-dft it was not clear that RuntimeEnv::new() actually returns a Result as the typical rust convention is a function new() is infallable and a function like try_new() is fallable. While this isn't a big deal it was a small usability papercut
Describe the solution you'd like
I would like RuntimeEnv to follow standard rust conventions to make it easier to use
Describe alternatives you've considered
I suggest:
- Deprecating
RuntimeEnv::new() - Add a new function
RuntimeEnv::try_new()that does the same thing - Update all the datafusion code to use
try_newinstead
Additional context
No response
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomers