-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Closed
Labels
enhancementNew feature or requestNew feature or request
Description
Is your feature request related to a problem or challenge?
We only support to convert JOIN with ON constraint to SQL String now. The SQL as below can't be converted now.
SELECT * FROM orders JOIN customer USING (custkey)
It will panic with the message:
NotImplemented("Unsupported join constraint: Using")
Describe the solution you'd like
The unparse rule for JOIN in datafusion/sql/src/unparser/plan.rs should be implemented.
datafusion/datafusion/sql/src/unparser/plan.rs
Lines 277 to 285 in 8bedecc
| LogicalPlan::Join(join) => { | |
| match join.join_constraint { | |
| JoinConstraint::On => {} | |
| JoinConstraint::Using => { | |
| return not_impl_err!( | |
| "Unsupported join constraint: {:?}", | |
| join.join_constraint | |
| ) | |
| } |
Describe alternatives you've considered
No response
Additional context
No response
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request