Skip to content

Avoid comparison coercion logic comparison_binary_numeric_coercion in non-comparison coercion logic coerced_from #10241

@jayzhan211

Description

@jayzhan211

Is your feature request related to a problem or challenge?

I think the logic between these two logic is easily misuse, before someone come out a nice way to handle coercion logic in one. I think we should keep them separate and refrain from mixing their use
#10221 (comment)

Describe the solution you'd like

Remove comparison_binary_numeric_coercion from coerced_from but avoid breaking existing logic.

_ => comparison_binary_numeric_coercion(type_into, type_from).and_then(
|coerced_type| {
if *type_into == coerced_type {
Some(coerced_type)
} else {
None
}
},
),

Describe alternatives you've considered

No response

Additional context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions