Skip to content

Remove ScalarFunctionDefinition #10175

@Omega359

Description

@Omega359

Is your feature request related to a problem or challenge?

As noted in #10098 (comment) The ScalarFunctionDefinition::Name is seemingly unused which means that ScalarFunctionDefinition is essentially a simple wrapper to Arc<crate::ScalarUDF> and thus may be a candidate for removal. This would simplify the code slightly and remove a number of code blocks such as

ScalarFunctionDefinition::Name(_) => {
    internal_err!("Function `Expr` with name should be resolved.")
}

Describe the solution you'd like

ScalaraFunctionDefinition is removed and all code references updated.

Describe alternatives you've considered

Leave the code as is. Or possibly just remove the ScalarFunctionDefinition::Name(_) enum

Additional context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions