Skip to content

Fix scaleio tests#7622

Merged
DaanHoogland merged 6 commits intoapache:mainfrom
shapeblue:fix-scaleio-tests
Jun 15, 2023
Merged

Fix scaleio tests#7622
DaanHoogland merged 6 commits intoapache:mainfrom
shapeblue:fix-scaleio-tests

Conversation

@vishesh92
Copy link
Copy Markdown
Member

@vishesh92 vishesh92 commented Jun 13, 2023 •
edited
Loading

Description

This PR fixes code coverage of scaleio.

The other plugins have the same setting.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@vishesh92 vishesh92 mentioned this pull request Jun 13, 2023
Closed
12 tasks
vishesh92
vishesh92 commented Jun 13, 2023
View reviewed changes
Comment thread ...c/test/java/org/apache/cloudstack/storage/datastore/client/ScaleIOGatewayClientImplTest.java
@RunWith(MockitoJUnitRunner.class)
public class ScaleIOGatewayClientImplTest {
private final int port = 443;
private final int port = 8443;
Copy link
Copy Markdown
Member Author

@vishesh92 vishesh92 Jun 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

443 is a restricted port in linux and needs root access. Used 8443 instead.

@vishesh92
Copy link
Copy Markdown
Member Author

vishesh92 commented Jun 13, 2023 •
edited
Loading

image

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 13, 2023 •
edited
Loading

Codecov Report

Merging #7622 (a74e9bd) into main (ae10263) will increase coverage by 0.08%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #7622      +/-   ##
============================================
+ Coverage     13.03%   13.12%   +0.08%     
- Complexity     9077     9144      +67     
============================================
  Files          2728     2728              
  Lines        256997   256997              
  Branches      40067    40067              
============================================
+ Hits          33509    33736     +227     
+ Misses       219284   219011     -273     
- Partials       4204     4250      +46
Impacted Files Coverage Δ
...d/kubernetes/cluster/KubernetesClusterService.java 100.00% <ø> (ø)

... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@DaanHoogland DaanHoogland reopened this Jun 13, 2023
@vishesh92
Fix testAttachZone
ef6e057 
Reduced the scope of the test to make it work
DaanHoogland
DaanHoogland reviewed Jun 13, 2023
View reviewed changes
Comment thread pom.xml Outdated
@vishesh92 vishesh92 marked this pull request as ready for review June 13, 2023 11:24
@yadvr yadvr added this to the 4.19.0.0 milestone Jun 15, 2023
@yadvr
Copy link
Copy Markdown
Member

yadvr commented Jun 15, 2023

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jun 15, 2023

@rohityadavcloud a [SF] Jenkins job has been kicked to build packages. It will be bundled with SystemVM template(s). I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jun 15, 2023

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6237

DaanHoogland
DaanHoogland approved these changes Jun 15, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Jun 15, 2023

only tests and pom.xmls changed, as this is building I'm m erging

@DaanHoogland DaanHoogland merged commit 27b0a64 into apache:main Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

Assignees

No one assigned

Labels

component:build component:primary-storage component:storage

Projects

None yet

Milestone

4.19.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@vishesh92 @yadvr @blueorangutan @DaanHoogland @weizhouapache