Change 2FA plugin related global setting names#7275
Conversation
|
@blueorangutan package |
|
@harikrishna-patnala a Jenkins job has been kicked to build packages. It will be bundled with SystemVM template(s). I'll keep you posted as I make progress. |
|
Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 5625 |
|
Kudos, SonarCloud Quality Gate passed!
|
|
@harikrishna-patnala this looks like a fix on a new feature . is this critical in any way (to go into 4.18)? |
Codecov Report
@@ Coverage Diff @@
## main #7275 +/- ##
============================================
- Coverage 12.67% 12.67% -0.01%
Complexity 8641 8641
============================================
Files 2716 2716
Lines 256112 256111 -1
Branches 39926 39926
============================================
- Hits 32461 32460 -1
Misses 219522 219522
Partials 4129 4129
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
this looks like a polish. |
|
if we are about to cut RC2 then can you include this as well in 4.18. This is more of a polish change, since this feature is included in 4.18 it is better to merge this 4.18 instead of 4.18.1 |
|
yes what @weizhouapache said |
|
@blueorangutan package |
vladimirpetrov
left a comment
There was a problem hiding this comment.
LGTM based on manual testing.
Description
This is related to the new improvement for 2FA in CloudStack #6924
In this PR we are changing the plugin related global setting names to be more relevant.
Types of changes
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?