Skip to content

UI - Hide shrink disk option on XCP-NG/Xenserver#5829

Merged
sureshanaparti merged 2 commits intoapache:4.16from
EWERK-DIGITAL:feature/volume-hide-shrinkok
Jan 6, 2022
Merged

UI - Hide shrink disk option on XCP-NG/Xenserver#5829
sureshanaparti merged 2 commits intoapache:4.16from
EWERK-DIGITAL:feature/volume-hide-shrinkok

Conversation

@utchoang
Copy link
Copy Markdown

@utchoang utchoang commented Jan 6, 2022

Description

This PR fixes #5698

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@utchoang utchoang changed the title hide shrink disk option on XCP-NG/Xenserver UI - Hide shrink disk option on XCP-NG/Xenserver Jan 6, 2022
@utchoang
Copy link
Copy Markdown
Author

utchoang commented Jan 6, 2022

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jan 6, 2022

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

sureshanaparti
sureshanaparti approved these changes Jan 6, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@sureshanaparti sureshanaparti added this to the 4.16.1.0 milestone Jan 6, 2022
shwstppr
shwstppr approved these changes Jan 6, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. However XCP-ng hosts, VMs and volumes return hypervisor as XenServer only

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jan 6, 2022

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5829 (SL-JID-979)

@sureshanaparti
Copy link
Copy Markdown
Contributor

sureshanaparti commented Jan 6, 2022

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jan 6, 2022

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jan 6, 2022

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5829 (SL-JID-980)

@sureshanaparti
Copy link
Copy Markdown
Contributor

sureshanaparti commented Jan 6, 2022

Minor UI change, smoke tests not needed.

@sureshanaparti sureshanaparti merged commit 3cbde8c into apache:4.16 Jan 6, 2022
@sureshanaparti sureshanaparti mentioned this pull request Jan 6, 2022
Closed
@JoaoJandre JoaoJandre mentioned this pull request Jun 11, 2025
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shwstppr shwstppr shwstppr approved these changes

@sureshanaparti sureshanaparti sureshanaparti approved these changes

@Pearl1594 Pearl1594 Awaiting requested review from Pearl1594

Assignees

No one assigned

Labels

component:UI

Projects

No open projects
Apache CloudStack 4.16.1
Status: Done

Milestone

4.16.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@utchoang @blueorangutan @sureshanaparti @shwstppr