fix qemu-img path in cloudstack sudoers#11614
Merged
weizhouapache merged 1 commit intoapache:4.20from Sep 12, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a configuration issue in CloudStack's sudoers file where qemu-img is not accessible in OpenSUSE systems due to a different installation path. The fix adds /usr/bin/qemu-img as an additional allowed command path alongside the existing /bin/qemu-img path.
- Adds
/usr/bin/qemu-imgto the CLOUDSTACK command alias in the sudoers configuration - Maintains backward compatibility by keeping the existing
/bin/qemu-imgpath
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Member
Author
|
@blueorangutan package |
|
@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.20 #11614 +/- ##
=========================================
Coverage 16.17% 16.17%
+ Complexity 13297 13296 -1
=========================================
Files 5656 5656
Lines 498136 498136
Branches 60432 60432
=========================================
+ Hits 80583 80585 +2
+ Misses 408585 408583 -2
Partials 8968 8968
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 14960 |
Member
|
@blueorangutan test |
|
@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
Member
|
verified OK the /etc/sudoers.d/cloudstack-management has been updated |
|
[SF] Trillian Build Failed (tid-14302) |
|
[SF] Trillian Build Failed (tid-14303) |
Member
|
Merging based on approvals and tests |
|
[SF] Trillian test result (tid-14298)
|
|
[SF] Trillian test result (tid-14297)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds another path for qemu-img. In Open SUSE,
/bin/qemu-imgdoesn't exist and this results in a faulty system VM template configuration as of now.Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?