another review comment

shwstppr · shwstppr · commit 175367baaa44 · 2023-05-31T15:46:09.000+05:30
Signed-off-by: Abhishek Kumar &lt;abhishek.mrt22@gmail.com&gt;
diff --git a/api/src/main/java/org/apache/cloudstack/api/command/admin/vm/MigrateVirtualMachineWithVolumeCmd.java b/api/src/main/java/org/apache/cloudstack/api/command/admin/vm/MigrateVirtualMachineWithVolumeCmd.java
@@ -150,6 +150,19 @@ public ApiCommandResourceType getApiResourceType() {
         return ApiCommandResourceType.VirtualMachine;
     }
 
+    private Host getDestinationHost() {
+        if (getHostId() == null) {
+            return null;
+        }
+        Host destinationHost = _resourceService.getHost(getHostId());
+        // OfflineVmwareMigration: destination host would have to not be a required parameter for stopped VMs
+        if (destinationHost == null) {
+            s_logger.error(String.format("Unable to find the host with ID [%s].", getHostId()));
+            throw new InvalidParameterValueException("Unable to find the specified host to migrate the VM.");
+        }
+        return destinationHost;
+    }
+
     @Override
     public void execute() {
         if (hostId == null && MapUtils.isEmpty(migrateVolumeTo) && !Boolean.TRUE.equals(autoSelect)) {
@@ -169,15 +182,7 @@ public void execute() {
         try {
             VirtualMachine migratedVm = null;
             if (getHostId() != null || Boolean.TRUE.equals(autoSelect)) {
-                Host destinationHost = null;
-                if (getHostId() != null) {
-                    destinationHost = _resourceService.getHost(getHostId());
-                    // OfflineVmwareMigration: destination host would have to not be a required parameter for stopped VMs
-                    if (destinationHost == null) {
-                        s_logger.error(String.format("Unable to find the host with ID [%s].", getHostId()));
-                        throw new InvalidParameterValueException("Unable to find the specified host to migrate the VM.");
-                    }
-                }
+                Host destinationHost = getDestinationHost();
                 migratedVm = _userVmService.migrateVirtualMachineWithVolume(getVirtualMachineId(), destinationHost, getVolumeToPool());
             } else if (MapUtils.isNotEmpty(migrateVolumeTo)) {
                 migratedVm = _userVmService.vmStorageMigration(getVirtualMachineId(), getVolumeToPool());
