Skip to content

fix: special case for gp_toolkit when gprestore close cloudberry #681#9

Closed
yihong0618 wants to merge 2 commits intoapache:mainfrom
yihong0618:main
Closed

fix: special case for gp_toolkit when gprestore close cloudberry #681#9
yihong0618 wants to merge 2 commits intoapache:mainfrom
yihong0618:main

Conversation

@yihong0618
Copy link

@yihong0618 yihong0618 commented Nov 4, 2024

fix apache/cloudberry#681

Change logs

Describe your change clearly, including what problem is being solved or what document is being added or updated.

There are two commits for this PR:

Contributor's checklist

Here are some reminders before you submit your pull request:

  • Make sure that your Pull Request has a clear title and commit message. You can take the Git commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution (One-time setup).
  • Learn the code contribution and doc contribution guides for better collaboration.
  • List your communications in the GitHub Issues or Discussions (if has or needed).
  • Feel free to ask for the cloudberrydb team to help review and approve.

AJR-VMware and others added 2 commits November 4, 2024 11:32
@AJR-VMware @yihong0618
Explicitly create extension schemas when needed
62479e7 
Recent changes to gp_toolkit on GPDB7+ break restores if the gp_toolkit
schema was not already created.  Further we currently hard-fail if an
extension is meant to be in a schema that was not prior created.

To address the gp_toolkit issue and provide some additional stability,
explicitly add a CREATE IF NOT EXISTS statement for extension schemas.
@yihong0618
fix: drop special code for gp version 7
e98356b 
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
@CLAassistant
Copy link

CLAassistant commented Nov 4, 2024 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ yihong0618
❌ AJR-VMware
You have signed the CLA already but the status is still pending? Let us recheck it.

@yihong0618 yihong0618 mentioned this pull request Nov 4, 2024
Open
2 tasks
@tuhaihe
Copy link
Member

tuhaihe commented Nov 4, 2024

Hi @yihong0618 thanks for your contribution!

@bobthomson70 bobthomson70 deleted the branch apache:main October 10, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fanfuxiaoran fanfuxiaoran Awaiting requested review from fanfuxiaoran

1 more reviewer

@Mulily0513 Mulily0513 Mulily0513 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] gprestore report : -ERROR: schema "gp_toolkit" does not exist (SQLSTATE 3F000)

6 participants

@yihong0618 @CLAassistant @tuhaihe @Mulily0513 @bobthomson70 @AJR-VMware