Skip to content

[skip ci] Doc: fix org change that link dead for discuss#707

Merged
tuhaihe merged 1 commit intoapache:mainfrom
yihong0618:hy/doc_org_fix
Nov 25, 2024
Merged

[skip ci] Doc: fix org change that link dead for discuss#707
tuhaihe merged 1 commit intoapache:mainfrom
yihong0618:hy/doc_org_fix

Conversation

@yihong0618
Copy link
Contributor

@yihong0618 yihong0618 commented Nov 8, 2024 •
edited
Loading

fix #ISSUE_Number

Change logs

As cloudberry the org changed to apache now, most of the links can redirect but for the discuss such as orgs/cloudberry/discuss can not, this PR fix that case.
you can try:
link dead: https://github.com/orgs/cloudberrydb/discussions/categories/proposal
link fixed: url: https://github.com/apache/cloudberrydb/discussions/categories/proposal

for the case it may graduate from apache some day so keep the urls can redirect first.

Why are the changes needed?

Describe why the changes are necessary.

Does this PR introduce any user-facing change?

If yes, please clarify the previous behavior and the change this PR proposes.

How was this patch tested?

Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
  • Learn the coding contribution guide, including our code conventions, workflow and more.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to request cloudberrydb/dev team for review and approval when your PR is ready🥳

github-actions[bot]
github-actions bot reviewed Nov 8, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiiii, @yihong0618 welcome!🎊 Thanks for taking the effort to make our project better! 🙌 Keep making such awesome contributions!

avamingli
avamingli previously approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@avamingli avamingli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@tuhaihe
Copy link
Member

tuhaihe commented Nov 11, 2024

Hi @yihong0618, thank you! There is already a PR #696 for the link changes. Please feel free to rebase your commit once #696 is merged.

BTW, welcome to take the git commit template to amend your commit title and body. Thanks again!

@yihong0618
Copy link
Contributor Author

yihong0618 commented Nov 22, 2024 •
edited
Loading

@tuhaihe the issue created is dead in cloudberry it will link a 404 page, maybe we can merge this two pull requests
when click these things it will be 404...
image

@tuhaihe
Copy link
Member

tuhaihe commented Nov 22, 2024

@tuhaihe the issue created is dead in cloudberry it will link a 404 page, maybe we can merge this two pull requests

Agreed. Welcome to rebase to trigger the CI (now can use the tag ‘skip ci ‘ to skip the checks) then merge it.

tuhaihe
tuhaihe requested changes Nov 22, 2024
View reviewed changes
Copy link
Member

@tuhaihe tuhaihe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yihong0618 welcome to resolve the conflicts.

Also please amend your commit messages per the template - https://github.com/apache/cloudberry/blob/main/.gitmessage, thanks.

@yihong0618
Doc: link 404 error caused by org changed
a8a3b23 
fix some of the links are wrong since org changed from cloudberry
to apache.

Signed-off-by: yihong0618 <zouzou0208@gmail.com>
@yihong0618
Copy link
Contributor Author

yihong0618 commented Nov 22, 2024

Hi @yihong0618 welcome to resolve the conflicts.

Also please amend your commit messages per the template - https://github.com/apache/cloudberry/blob/main/.gitmessage, thanks.

done

@tuhaihe tuhaihe changed the title doc: fix org change that link dead for discuss [skip ci] Doc: fix org change that link dead for discuss Nov 22, 2024
@tuhaihe tuhaihe requested a review from avamingli November 22, 2024 05:16
@tuhaihe
Copy link
Member

tuhaihe commented Nov 22, 2024 •
edited
Loading

Hi @edespino have added the tag skip ci to the PR title, but it seems that we still cannot skip the build. FYI.

@edespino
Copy link
Contributor

edespino commented Nov 22, 2024

@tuhaihe - I believe the [skip ci] will work but it has be in the PR title when the PR is created. Please give it a try with the next PR which does not need a build. You can also test it with a draft PR and then close it.

@tuhaihe tuhaihe requested review from edespino and reshke November 22, 2024 06:19
@tuhaihe tuhaihe merged commit 43c915c into apache:main Nov 25, 2024
@yihong0618 yihong0618 deleted the hy/doc_org_fix branch November 25, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@tuhaihe tuhaihe tuhaihe approved these changes

@gfphoenix78 gfphoenix78 gfphoenix78 approved these changes

@avamingli avamingli Awaiting requested review from avamingli

@edespino edespino Awaiting requested review from edespino

@reshke reshke Awaiting requested review from reshke

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yihong0618 @tuhaihe @edespino @avamingli @gfphoenix78