JAVA-2995 make CodecNotFoundException extend DriverException#1598
Conversation
|
@adutra would you mind to take a look? I just found this low-hanger as I was creating 3022 :D |
ad646dc to
9f7fdc0
Compare
adutra
left a comment
There was a problem hiding this comment.
As discussed in the Jira ticket, I'd like to see a note in the upgrade guide because this is in theory a breaking change, which is not allowed in a minor version.
|
@adutra please run the build again, I addressed your comments. |
|
I pushed a few fixes for the upgrade guide. I think this is looking good but I'm still torn on the idea of including this breaking change in a minor. I will leave this open for now and wait for others to chime in, maybe @absurdfarce ? |
|
I too have been going back and forth on the question of whether we roll this out in anything less than a major release, and I think ultimately I'd argue that we shouldn't. While the risk of surprising behaviour for this specific change may be fairly small it certainly is a possibility for some users... and I'd rather be very clear about that from a semver perspective. |
|
After sleeping on this I'm reversing myself; I'm going to put this into 4.15.0 with a note in the upgrade guide. It's very consistent with how we've handled similar issues in the past, and going to 5.0 for this change seems like it would create more confusion (to say nothing of false expectations of major new features/improvements). |
No description provided.