Issue 3567: Upgrade rocksdb version to avoid checksum mismatch error #3568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
lgtm. |
hangc0276
requested changes
Oct 25, 2022
Contributor
hangc0276
left a comment
There was a problem hiding this comment.
It upgrades the major version of the RocksDB(7.x), and I'm not sure whether it can compatible with the current RocksDB version (6.x). Does RocksDB 6.x contains this fix?
Contributor
|
@zhaohaidao Would you please start a discussion in the dev mail list for upgrading RocksDB to 7.x? |
Contributor
Author
Ok, I will take the time to launch the discussion in the near future, thank you for reminding |
Contributor
|
The RocksDB version has been upgraded to 7.9.2, close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Rocksdb instance throws Checksum Mismatch exception frequently in high workload(2000MB/s with 3 bookies and 3 replica) with directio mode.
I checked the release history of rocksdb and found that checksum mismatch bug maybe fixed after 7.4.0. The fix is followed
WriteBatchInternal::Append()where WAL termination point in write batch was not considered and the function appends an incorrect number of checksums.Changes
Upgrade rocksdb version to 7.4.5 to avoid checksum mismatch error
After rocksdb upgraded to 7.4.5. Checksum mismatch error no longer appears
Master Issue: #3567