Upgrade google-cloud-core and google-cloud-bigquery dependencies#9162
Merged
aaltay merged 1 commit intoapache:masterfrom Jul 26, 2019
Merged
Upgrade google-cloud-core and google-cloud-bigquery dependencies#9162aaltay merged 1 commit intoapache:masterfrom
aaltay merged 1 commit intoapache:masterfrom
Conversation
udim
reviewed
Jul 26, 2019
| 'google-cloud-bigquery>=1.6.0,<1.7.0', | ||
| 'google-cloud-core>=0.28.1,<0.30.0', | ||
| 'google-cloud-bigquery>=1.6.0,<1.18.0', | ||
| 'google-cloud-core>=0.28.1,<2', |
Member
Author
There was a problem hiding this comment.
No I meant 2.
It does not look like 0.x to 1.x change was breaking. Beam could support both 0.x and 1.x ranges. 2 is not released. Added <2 to protect against future changes.
Member
Author
|
Run Python 2 PostCommit |
1 similar comment
Member
Author
|
Run Python 2 PostCommit |
udim
approved these changes
Jul 26, 2019
Member
Author
|
Run Python 3.5 PostCommit |
1 similar comment
Member
Author
|
Run Python 3.5 PostCommit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade google-cloud-core and google-cloud-bigquery dependencies
google-cloud-core dependency recently got upgraded to 1.x and other google io dependency may depend on this range (e.g. firestore)
According to change log there is not a big breaking change (https://googleapis.dev/python/google-cloud-core/latest/changelog.html). Tests will tell us better.
Also bigquery package needs to be updated as well based on the above change log.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.